[all-commits] [llvm/llvm-project] a79c01: Revert "[lld-macho] Have path-related functions re...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a79c01832553a8a192ab157098662a9e8f2c16af
      https://github.com/llvm/llvm-project/commit/a79c01832553a8a192ab157098662a9e8f2c16af
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/Driver.h
    M lld/MachO/DriverUtils.cpp

  Log Message:
  -----------
  Revert "[lld-macho] Have path-related functions return std::string, not StringRef"

This reverts commit 1d31fb8d122b1117cf20a9edc09812db8472e930.

Making `rerootPath` return a temporary std::string caused a
use-after-free:

https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/1608/overview


  Commit: 4507f64165fd0c95f08b66d61db39549b22c50d3
      https://github.com/llvm/llvm-project/commit/4507f64165fd0c95f08b66d61db39549b22c50d3
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/test/MachO/archive.s
    M lld/test/MachO/force-load.s

  Log Message:
  -----------
  [re-land][lld-macho] Avoid force-loading the same archive twice

This reverts commit c9b241efd68c5a0f1f67e9250960ade454f3bc11, which was
a backout diff to fix the buildbots.

The real culprit of the crash is
https://github.com/llvm/llvm-project/commit/1d31fb8d122b1117cf20a9edc09812db8472e930,
which is being reverted.

Differential Revision: https://reviews.llvm.org/D104353


Compare: https://github.com/llvm/llvm-project/compare/671a87104b81...4507f64165fd