[all-commits] [llvm/llvm-project] fb32de: Re-Revert "DirectoryWatcher: add an implementation...

Nico Weber via All-commits all-commits at lists.llvm.org
Fri Jun 18 15:52:48 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fb32de9e97af0921242a021e30020ffacf7aa6e2
      https://github.com/llvm/llvm-project/commit/fb32de9e97af0921242a021e30020ffacf7aa6e2
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp
    M clang/unittests/DirectoryWatcher/CMakeLists.txt

  Log Message:
  -----------
  Re-Revert "DirectoryWatcher: add an implementation for Windows"

This reverts commit 76f1baa7875acd88bdd4b431eed6e2d2decfc0fe.

Also reverts 2 follow-ups:

1. Revert "DirectoryWatcher: also wait for the notifier thread"
   This reverts commit 527a1821e6f8e115db3335a3341c7ac491725a0d.

2. Revert "DirectoryWatcher: close a possible window of race on Windows"
   This reverts commit a6948da86ad7e78d66b26263c2681ef6385cc234.

Makes tests hang, see comments on https://reviews.llvm.org/D88666




More information about the All-commits mailing list