[all-commits] [llvm/llvm-project] ec91df: Delay initialization of OptBisect

Krzysztof Parzyszek via All-commits all-commits at lists.llvm.org
Fri Jun 18 11:15:42 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec91df8d8195b8b759a89734dba227da1eaa729f
      https://github.com/llvm/llvm-project/commit/ec91df8d8195b8b759a89734dba227da1eaa729f
  Author: Krzysztof Parzyszek <kparzysz at quicinc.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M llvm/include/llvm/IR/OptBisect.h
    M llvm/lib/IR/OptBisect.cpp

  Log Message:
  -----------
  Delay initialization of OptBisect

When LLVM is used in other projects, it may happen that global cons-
tructors will execute before the call to ParseCommandLineOptions.
Since OptBisect is initialized via a constructor, and has no ability
to be updated at a later time, passing "-opt-bisect-limit" to the
parse function may have no effect.

To avoid this problem use a cl::cb (callback) to set the bisection
limit when the option is actually processed.

Differential Revision: https://reviews.llvm.org/D104551


  Commit: c1e6d25a0285b7825ef74690c622c47fb0123245
      https://github.com/llvm/llvm-project/commit/c1e6d25a0285b7825ef74690c622c47fb0123245
  Author: Krzysztof Parzyszek <kparzysz at quicinc.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M llvm/test/DebugInfo/Generic/missing-abstract-variable.ll

  Log Message:
  -----------
  XFAIL a testcase on Hexagon (missing-abstract-variable.ll)

This seems to be a common problem among several architectures.


Compare: https://github.com/llvm/llvm-project/compare/5c189d30e60a...c1e6d25a0285


More information about the All-commits mailing list