[all-commits] [llvm/llvm-project] aa4685: [lldb-vscode] only report long running progress ev...
walter erquinigo via All-commits
all-commits at lists.llvm.org
Thu Jun 17 12:13:39 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: aa4685c0fb3aab5acb90be5fd3eb5ba8bf1e3211
https://github.com/llvm/llvm-project/commit/aa4685c0fb3aab5acb90be5fd3eb5ba8bf1e3211
Author: Walter Erquinigo <a20012251 at gmail.com>
Date: 2021-06-17 (Thu, 17 Jun 2021)
Changed paths:
M lldb/tools/lldb-vscode/ProgressEvent.cpp
M lldb/tools/lldb-vscode/ProgressEvent.h
M lldb/tools/lldb-vscode/VSCode.cpp
M lldb/tools/lldb-vscode/VSCode.h
M lldb/tools/lldb-vscode/lldb-vscode.cpp
Log Message:
-----------
[lldb-vscode] only report long running progress events
When the number of shared libs is massive, there could be hundreds of
thousands of short lived progress events sent to the IDE, which makes it
irresponsive while it's processing all this data. As these small jobs
take less than a second to process, the user doesn't even see them,
because the IDE only display the progress of long operations. So it's
better not to send these events.
I'm fixing that by sending only the events that are taking longer than 5
seconds to process.
In a specific run, I got the number of events from ~500k to 100, because
there was only 1 big lib to parse.
I've tried this on several small and massive targets, and it seems to
work fine.
Differential Revision: https://reviews.llvm.org/D101128
More information about the All-commits
mailing list