[all-commits] [llvm/llvm-project] 758633: [lld][WebAssembly] Add new `--import-undefined` op...

Sam Clegg via All-commits all-commits at lists.llvm.org
Thu Jun 17 11:51:15 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 758633f92226ad25c9007a8a05f01cb848b97ab8
      https://github.com/llvm/llvm-project/commit/758633f92226ad25c9007a8a05f01cb848b97ab8
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2021-06-17 (Thu, 17 Jun 2021)

  Changed paths:
    M lld/docs/WebAssembly.rst
    M lld/test/wasm/unresolved-symbols.s
    M lld/wasm/Config.h
    M lld/wasm/Driver.cpp
    M lld/wasm/Options.td
    M lld/wasm/Relocations.cpp
    M lld/wasm/Writer.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Add new `--import-undefined` option

This change revisits https://reviews.llvm.org/D79248 which originally
added support for the --unresolved-symbols flag.

At the time I thought it would make sense to add a third option to this
flag called `import-functions` but it turns out (as was suspects by on
the reviewers IIRC) that this option can be authoganal.

Instead I've added a new option called `--import-undefined` that only
operates on symbols that can be imported (for example, function symbols
can always be imported as opposed to data symbols we can only be
imported when compiling with PIC).

This option gives us the full expresivitiy that emscripten needs to be
able allow reporting of undefined data symbols as well as the option to
disable that.

This change does remove the `--unresolved-symbols=import-functions`
option, which is been in the codebase now for about a year but I would
be extremely surprised if anyone was using it.

Differential Revision: https://reviews.llvm.org/D103290




More information about the All-commits mailing list