[all-commits] [llvm/llvm-project] fa1de8: [DebugInfo] Prevent non-determinism when updating ...

[Stephen Tozer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fa1de88f81e9c6db5255ca7c4d0fd25606c5a054
      https://github.com/llvm/llvm-project/commit/fa1de88f81e9c6db5255ca7c4d0fd25606c5a054
  Author: Stephen Tozer <Stephen.Tozer at Sony.com>
  Date:   2021-06-17 (Thu, 17 Jun 2021)

  Changed paths:
    M llvm/lib/IR/Metadata.cpp

  Log Message:
  -----------
  [DebugInfo] Prevent non-determinism when updating DIArgList users of a value

This patch fixes an issue where builds of programs with multiple dbg.values
with DIArgList locations could have non-deterministic output. This issue
was caused by ReplaceableMetadataImpl::getAllArgListUsers, which
returned DIArgList pointers in a random order; the output of this
function would later be used to insert dbg.values, causing the order of
insertion to be non-deterministic. This patch changes getAllArgListUsers
to return pointers in a fixed order.

Differential Revision: https://reviews.llvm.org/D104105