[all-commits] [llvm/llvm-project] 1a4af2: [flang] preserve symbol in DescriptorInquiry

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a4af2e45ee59cff3d577986b9b7f3f5bd5ab01f
      https://github.com/llvm/llvm-project/commit/1a4af2e45ee59cff3d577986b9b7f3f5bd5ab01f
  Author: Jean Perier <jperier at nvidia.com>
  Date:   2021-06-17 (Thu, 17 Jun 2021)

  Changed paths:
    M flang/lib/Evaluate/shape.cpp
    M flang/lib/Evaluate/variable.cpp

  Log Message:
  -----------
  [flang] preserve symbol in DescriptorInquiry

Do not use ultimate symbols in DescriptorInquiry. Using the ultimate
symbol may lead to issues later for at least two reasons:

- The original symbols may have volatile/asynchronous attributes that
  the ultimate may not have. Later phases working on the DescriptorInquiry
  would then not apply potential care required by these attributes.
- HostAssociatedDetails symbols are used by OpenMP for symbols with
  special OpenMP attributes inside OpenMP region (e.g variables with
  private attribute), so it is very important to preserve this
  aspect in the DescriptorInquiry, that would otherwise apply on the
  symbol outside of the region.

Differential Revision: https://reviews.llvm.org/D104385