[all-commits] [llvm/llvm-project] b8bbb9: [lld-macho][nfc] Put back shouldOmitFromOutput() a...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b8bbb9723af3ab5bfa11366480ecf42b45680101
      https://github.com/llvm/llvm-project/commit/b8bbb9723af3ab5bfa11366480ecf42b45680101
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-16 (Wed, 16 Jun 2021)

  Changed paths:
    M lld/MachO/InputSection.cpp
    M lld/MachO/InputSection.h
    M lld/MachO/MapFile.cpp
    M lld/MachO/UnwindInfoSection.cpp

  Log Message:
  -----------
  [lld-macho][nfc] Put back shouldOmitFromOutput() asserts

I removed them in rG5de7467e982 but @thakis pointed out that
they were useful to keep, so here they are again. I've also converted
the `!isCoalescedWeak()` asserts into `!shouldOmitFromOutput()` asserts,
since the latter check subsumes the former.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D104169


  Commit: eeac6b2beceeb82382354d730b615159af3bc70e
      https://github.com/llvm/llvm-project/commit/eeac6b2beceeb82382354d730b615159af3bc70e
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-16 (Wed, 16 Jun 2021)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/test/MachO/lc-linker-option.ll

  Log Message:
  -----------
  [lld-macho] Handle multiple LC_LINKER_OPTIONs

We previously only parsed the first one.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D104352


  Commit: 560636e5497a85d036a39ad5bf599d26828f66b3
      https://github.com/llvm/llvm-project/commit/560636e5497a85d036a39ad5bf599d26828f66b3
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-16 (Wed, 16 Jun 2021)

  Changed paths:
    M lld/MachO/OutputSegment.cpp
    M lld/test/MachO/linkedit-contiguity.s

  Log Message:
  -----------
  [lld-macho] Put DATA_IN_CODE immediately after FUNCTION_STARTS

codesign checks for this.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D104354


Compare: https://github.com/llvm/llvm-project/compare/d619cf5ac5bf...560636e5497a