[all-commits] [llvm/llvm-project] 8ba9ee: [flang] Correct the subscripts used for arguments ...

[Peter Klausler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ba9ee46e465a56a54f8361703d3af7f4bc98d63
      https://github.com/llvm/llvm-project/commit/8ba9ee46e465a56a54f8361703d3af7f4bc98d63
  Author: peter klausler <pklausler at nvidia.com>
  Date:   2021-06-16 (Wed, 16 Jun 2021)

  Changed paths:
    M flang/runtime/character.cpp
    M flang/runtime/descriptor.cpp
    M flang/runtime/descriptor.h
    M flang/runtime/transformational.cpp
    M flang/unittests/Evaluate/reshape.cpp
    M flang/unittests/RuntimeGTest/CharacterTest.cpp

  Log Message:
  -----------
  [flang] Correct the subscripts used for arguments to character intrinsics

When chasing down another unrelated bug, I noticed that the
implementations of various character intrinsic functions assume
that the lower bounds of (some of) their arguments were 1.
This isn't necessarily the case, so I've cleaned them up, tweaked
the unit tests to exercise the fix, and regularized the allocation
pattern used for results to use SetBounds() before Allocate() rather
than the old original Descriptor::Allocate() wrapper around
CFI_allocate().

Since there were few other remaining uses of the old original
Descriptor::Allocate() wrapper, I also converted them to the
new one and deleted the old one.

Differential Revision: https://reviews.llvm.org/D104325