[all-commits] [llvm/llvm-project] a6948d: DirectoryWatcher: close a possible window of race ...

Saleem Abdulrasool via All-commits all-commits at lists.llvm.org
Tue Jun 15 09:16:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6948da86ad7e78d66b26263c2681ef6385cc234
      https://github.com/llvm/llvm-project/commit/a6948da86ad7e78d66b26263c2681ef6385cc234
  Author: Saleem Abdulrasool <compnerd at compnerd.org>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp

  Log Message:
  -----------
  DirectoryWatcher: close a possible window of race on Windows

The initial scan occurring before the watcher is ready allows a race
condition where a change occurs before the initial scan completes.
Ensure that we wait for the watcher to begin executing the initial scan.

Addresses some feedback from Adrian McCarthy in post-commit review.




More information about the All-commits mailing list