[all-commits] [llvm/llvm-project] cfe117: [Polly][Isl] Replacing isl method `to_str()` with ...

[Riccardo Mori via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cfe117def7b0714e5d724c80839e68f40fba4f47
      https://github.com/llvm/llvm-project/commit/cfe117def7b0714e5d724c80839e68f40fba4f47
  Author: patacca <patacca at autistici.org>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M polly/include/polly/Support/GICHelper.h
    M polly/include/polly/Support/ISLOStream.h
    M polly/lib/Analysis/PolyhedralInfo.cpp
    M polly/lib/Analysis/ScopBuilder.cpp
    M polly/lib/Analysis/ScopInfo.cpp
    M polly/lib/CodeGen/IslAst.cpp
    M polly/lib/External/isl/include/isl/isl-noexceptions.h
    M polly/lib/Support/GICHelper.cpp
    M polly/lib/Support/ISLTools.cpp

  Log Message:
  -----------
  [Polly][Isl] Replacing isl method `to_str()` with `stringFromIslObj()`. NFC.

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in `lib/External/isl/include/isl/isl-noxceptions.h` and the official isl C++ interface.

Changes made:
 - Removing method `to_str()` from all the classes in the isl C++ bindings.
 - Overload method `stringFromIslObj()` so it accepts isl C++ objects.
 - To keep backward compatibility `stringFromIslObj()` now accepts a value that is returned if the isl C object is `null` or doesn't have a string representation (by default it's an empty string). In some cases it's better to have the string "null" instead of an empty string.
 - isl-noexceptions.h has been generated by this https://github.com/patacca/isl/commit/d33ec3a3bbaf971b254a853e6d8200ff9f5a1385

Reviewed By: Meinersbur

Differential Revision: https://reviews.llvm.org/D104211