[all-commits] [llvm/llvm-project] beb521: [MCA][InstrBuilder] Check for the presence of flag...

Andrea Di Biagio via All-commits all-commits at lists.llvm.org
Tue Jun 15 01:54:03 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: beb5213a2ee56bbf554ccdd1908c48d10e244dab
      https://github.com/llvm/llvm-project/commit/beb5213a2ee56bbf554ccdd1908c48d10e244dab
  Author: Andrea Di Biagio <andrea.dibiagio at sony.com>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M llvm/lib/MCA/InstrBuilder.cpp
    M llvm/test/tools/llvm-mca/ARM/cortex-a57-carryover.s

  Log Message:
  -----------
  [MCA][InstrBuilder] Check for the presence of flag VariadicOpsAreDefs.

This patch fixes the logic that checks for variadic register definitions,

Before llvm-svn 348114 (commit 4cf35b4ab0b), it was not possible to explicitly
mark variadic operands as definitions. By default, variadic operands of an
MCInst were always assumed to be uses. A number of had-hoc checks were
introduced in the InstrBuilder to fix the processing of variadic register
operands of ARM ldm/stm variants.

This patch simply replaces those old (and buggy) checks with a much simpler (and
correct) check for MCID::Flag::VariadicOpsAreDefs.




More information about the All-commits mailing list