[all-commits] [llvm/llvm-project] d0a5d8: [Debug-Info][CodeView] Fix GUID string generation ...

[Carlos Alberto Enciso via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d0a5d8611935b548e1ec546b49201d47ac0a762c
      https://github.com/llvm/llvm-project/commit/d0a5d8611935b548e1ec546b49201d47ac0a762c
  Author: CarlosAlbertoEnciso <carlos.alberto.enciso at gmail.com>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M llvm/lib/DebugInfo/CodeView/Formatters.cpp
    A llvm/test/tools/obj2yaml/COFF/Inputs/test-1.o
    A llvm/test/tools/obj2yaml/COFF/Inputs/test-2.o
    A llvm/test/tools/obj2yaml/COFF/Inputs/test-3.o
    A llvm/test/tools/obj2yaml/COFF/Inputs/test-4.o
    A llvm/test/tools/obj2yaml/COFF/Inputs/test-5.o
    A llvm/test/tools/obj2yaml/COFF/Inputs/test-6.o
    A llvm/test/tools/obj2yaml/COFF/test-1.test
    A llvm/test/tools/obj2yaml/COFF/test-2.test
    A llvm/test/tools/obj2yaml/COFF/test-3.test
    A llvm/test/tools/obj2yaml/COFF/test-4.test
    A llvm/test/tools/obj2yaml/COFF/test-5.test
    A llvm/test/tools/obj2yaml/COFF/test-6.test
    M llvm/unittests/DebugInfo/CodeView/CMakeLists.txt
    A llvm/unittests/DebugInfo/CodeView/GUIDFormatTest.cpp

  Log Message:
  -----------
  [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects.

This patch is to address https://bugs.llvm.org/show_bug.cgi?id=50459.
  YAML:455:28: error: GUID strings are 38 characters long

The valid format for a GUID is {XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}
where X is a hex digit (0,1,2,3,4,5,6,7,8,9,A,B,C,D,E,F).
The length of the individual components must be: 8, 4, 4, 4, 12.

For some cases, the converted string generated by obj2yaml, does not
comply with those lengths. yaml2obj checks that the GUID string must
be 38 characters including the dashes and braces.

Reviewed By: amccarth

Differential Revision: https://reviews.llvm.org/D103089