[all-commits] [llvm/llvm-project] 3be5db: Make clangd CompletionModel usable even with non-s...

Harald van Dijk via All-commits all-commits at lists.llvm.org
Mon Jun 14 11:23:20 PDT 2021


  Branch: refs/heads/release/12.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 3be5dbbc32dd348dddcec9e3baec96b7dcef8a35
      https://github.com/llvm/llvm-project/commit/3be5dbbc32dd348dddcec9e3baec96b7dcef8a35
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2021-06-14 (Mon, 14 Jun 2021)

  Changed paths:
    M clang-tools-extra/clangd/quality/CompletionModel.cmake

  Log Message:
  -----------
  Make clangd CompletionModel usable even with non-standard (but supported) layout

llvm supports specifying a non-standard layout where each project lies in its
own place. Do not assume a fixed layout and use the appropriate cmake variable
instead.

Differential Revision: https://reviews.llvm.org/D96787

(cherry picked from commit f51ab1871655a9a96134c2636c37dcb5a6b01ac3)


  Commit: adae17728bad62fa9ce1635905d0b0bde30e3eba
      https://github.com/llvm/llvm-project/commit/adae17728bad62fa9ce1635905d0b0bde30e3eba
  Author: Harald van Dijk <harald at gigawatt.nl>
  Date:   2021-06-14 (Mon, 14 Jun 2021)

  Changed paths:
    M clang-tools-extra/clangd/quality/CompletionModel.cmake

  Log Message:
  -----------
  Make clangd CompletionModel not depend on directory layout.

The current code accounts for two possible layouts, but there is at
least a third supported layout: clang-tools-extra may also be checked
out as clang/tools/extra with the releases, which was not yet handled.
Rather than treating that as a special case, use the location of
CompletionModel.cmake to handle all three cases. This should address the
problems that prompted D96787 and the problems that prompted the
proposed revert D100625.

Reviewed By: usaxena95

Differential Revision: https://reviews.llvm.org/D101851

(cherry picked from commit 7907c46fe6195728fafd843b8c0fb19a3e68e9ad)


Compare: https://github.com/llvm/llvm-project/compare/7cc5b1593554...adae17728bad


More information about the All-commits mailing list