[all-commits] [llvm/llvm-project] 8c5a44: [OpaquePtr] Remove existing support for forward co...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c5a44901cafa5c848d3f2f2c26a23e6583ed657
      https://github.com/llvm/llvm-project/commit/8c5a44901cafa5c848d3f2f2c26a23e6583ed657
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2021-06-14 (Mon, 14 Jun 2021)

  Changed paths:
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/Bitcode/Reader/ValueList.cpp
    M llvm/lib/Bitcode/Reader/ValueList.h

  Log Message:
  -----------
  [OpaquePtr] Remove existing support for forward compatibility

It assumes that PointerType will keep having an optional pointee type,
but we'd like to remove the pointee type in PointerType at some point.

I feel like the current implementation could be simplified anyway,
although perhaps I'm underestimating the amount of work needed
throughout BitcodeReader.

We will still need a side table to keep track of pointee types. This
will be reimplemented at some point.

This is essentially a revert of a4771e9d (which doesn't look like it was
reviewed anyway).

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D103135