[all-commits] [llvm/llvm-project] 527a18: DirectoryWatcher: also wait for the notifier thread

[Saleem Abdulrasool via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 527a1821e6f8e115db3335a3341c7ac491725a0d
      https://github.com/llvm/llvm-project/commit/527a1821e6f8e115db3335a3341c7ac491725a0d
  Author: Saleem Abdulrasool <compnerd at compnerd.org>
  Date:   2021-06-13 (Sun, 13 Jun 2021)

  Changed paths:
    M clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp

  Log Message:
  -----------
  DirectoryWatcher: also wait for the notifier thread

Ultimately the DirectoryWatcher is not ready until the notifier thread
is also active.  Failure to wait for the notifier thread may result in
loss of events.  While this is not catastrophic in practice, the tests
are sensitive to this as depending on the thread scheduler, the thread
may fail to being execution before the operations are completed by the
fixture.  Running this in a tight loop shows no regressions locally as
previously, but this failure mode was been sighted once on a builder.