[all-commits] [llvm/llvm-project] 00ebbe: [ms] [llvm-ml] Make variable redefinition match ML...

Eric Astor via All-commits all-commits at lists.llvm.org
Thu Jun 10 05:36:52 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00ebbedd1c92f7461f81e79bd1474e894fd25378
      https://github.com/llvm/llvm-project/commit/00ebbedd1c92f7461f81e79bd1474e894fd25378
  Author: Eric Astor <epastor at google.com>
  Date:   2021-06-10 (Thu, 10 Jun 2021)

  Changed paths:
    M llvm/lib/MC/MCParser/MasmParser.cpp
    A llvm/test/tools/llvm-ml/variable_redef.asm
    A llvm/test/tools/llvm-ml/variable_redef_errors.asm

  Log Message:
  -----------
  [ms] [llvm-ml] Make variable redefinition match ML.EXE

MASM specifies that all variable definitions are redefinable, except for EQU definitions to expressions. (TEXTEQU is unspecified, but appears to be fully redefinable as well.)

Also, in practice, ML.EXE allows redefinitions where the value doesn't change.

Make variable redefinition possible for text macros, suppressing expansion if written as the first argument to an EQU or TEXTEQU directive.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D103993




More information about the All-commits mailing list