[all-commits] [llvm/llvm-project] 1b21e9: Add a static assertions for custom Op<> to not def...

[Mehdi Amini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b21e9c1fa990a303fa5a543c17a5f470a32e112
      https://github.com/llvm/llvm-project/commit/1b21e9c1fa990a303fa5a543c17a5f470a32e112
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2021-06-09 (Wed, 09 Jun 2021)

  Changed paths:
    M mlir/include/mlir/IR/OpDefinition.h

  Log Message:
  -----------
  Add a static assertions for custom Op<> to not defined data members (NFC)

A common mistake for newcomers to MLIR is to try to store extra member
on the Op class. However these are intended to be thing wrapper around
an Operation*, all the storage is meant to be encoded in attribute on
the underlying Operation. This can be confusing to debug, so better
catch it at build time.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D103869