[all-commits] [llvm/llvm-project] 56f60a: [mlir][spirv] Use SingleBlock + NoTerminator for s...

Lei Zhang via All-commits all-commits at lists.llvm.org
Wed Jun 9 11:04:25 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 56f60a1ce7656654d4b2f0cc42b2c5a15653db83
      https://github.com/llvm/llvm-project/commit/56f60a1ce7656654d4b2f0cc42b2c5a15653db83
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-06-09 (Wed, 09 Jun 2021)

  Changed paths:
    M mlir/docs/Dialects/SPIR-V.md
    M mlir/docs/SPIRVToLLVMDialectConversion.md
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
    M mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt
    M mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
    R mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.td
    M mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/Dialect/SPIRV/Linking/ModuleCombiner/ModuleCombiner.cpp
    M mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    M mlir/test/Conversion/SPIRVToLLVM/module-ops-to-llvm.mlir
    M mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
    M mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

  Log Message:
  -----------
  [mlir][spirv] Use SingleBlock + NoTerminator for spv.module

This allows us to remove the `spv.mlir.endmodule` op and
all the code associated with it.

Along the way, tightened the APIs for `spv.module` a bit
by removing some aliases. Now we use `getRegion` to get
the only region, and `getBody` to get the region's only
block.

Reviewed By: mravishankar, hanchung

Differential Revision: https://reviews.llvm.org/D103265




More information about the All-commits mailing list