[all-commits] [llvm/llvm-project] f492c3: [mlir-lsp-server] Add support for hover on region ...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f492c35965036d67833dae3c21498dcd1c1ed1fe
      https://github.com/llvm/llvm-project/commit/f492c35965036d67833dae3c21498dcd1c1ed1fe
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-06-07 (Mon, 07 Jun 2021)

  Changed paths:
    M mlir/include/mlir/IR/SymbolTable.h
    M mlir/lib/IR/SymbolTable.cpp
    M mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp
    M mlir/test/mlir-lsp-server/hover.test

  Log Message:
  -----------
  [mlir-lsp-server] Add support for hover on region operations

This revision adds support for hover on region operations, by temporarily removing the regions during printing. This revision also tweaks the hover format for operations to include symbol information, now that FuncOp can be shown in the hover.

Differential Revision: https://reviews.llvm.org/D103727


  Commit: 4c3adea7a4ab7c63010a953547152d4ad861f9de
      https://github.com/llvm/llvm-project/commit/4c3adea7a4ab7c63010a953547152d4ad861f9de
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-06-07 (Mon, 07 Jun 2021)

  Changed paths:
    M mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp
    M mlir/test/mlir-lsp-server/hover.test

  Log Message:
  -----------
  [mlir-lsp-server] Add support for hover on symbol references

For now the hover simply shows the same information as hovering on the operation
name. If necessary this can be tweaked to something symbol specific later.

Differential Revision: https://reviews.llvm.org/D103728


  Commit: 2db4701cafd42d20f32c6c9a5dbd15484523fcda
      https://github.com/llvm/llvm-project/commit/2db4701cafd42d20f32c6c9a5dbd15484523fcda
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-06-07 (Mon, 07 Jun 2021)

  Changed paths:
    M mlir/lib/Parser/AsmParserState.cpp
    M mlir/test/mlir-lsp-server/references.test

  Log Message:
  -----------
  [mlir-lsp-server] Fix bug in symbol use/def tracking

We were accidentally only using the first found reference, instead of all of them. This revision fixes this by properly tracking all references to a symbol.

Differential Revision: https://reviews.llvm.org/D103730


Compare: https://github.com/llvm/llvm-project/compare/17c43c404535...2db4701cafd4