[all-commits] [llvm/llvm-project] 2b9b96: [LLD][COFF] Reduce the maximum size of the GHASH t...

Alexandre Ganea via All-commits all-commits at lists.llvm.org
Fri May 28 07:03:19 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b9b9652ce27467283ae90a767af57d838a2465b
      https://github.com/llvm/llvm-project/commit/2b9b9652ce27467283ae90a767af57d838a2465b
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2021-05-28 (Fri, 28 May 2021)

  Changed paths:
    M lld/COFF/DebugTypes.cpp

  Log Message:
  -----------
  [LLD][COFF] Reduce the maximum size of the GHASH table

Before this patch, the maximum size of the GHASH table was 2^31 buckets. However we were storing the bucket index into a TypeIndex which has an input limit of (2^31)-4095 indices, see this link. Any value above that limit will improperly set the TypeIndex's high bit, which is interpreted as DecoratedItemIdMask. This used to cause bad indices on extraction when calling TypeIndex::toArrayIndex().

Differential Revision: https://reviews.llvm.org/D103297




More information about the All-commits mailing list