[all-commits] [llvm/llvm-project] 8d2576: Fix non-global-value-max-name-size not considered ...

[Mehdi Amini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d25762720660aba3344752e577ae7017e6125c2
      https://github.com/llvm/llvm-project/commit/8d25762720660aba3344752e577ae7017e6125c2
  Author: Hasyimi Bahrudin <hasyimi at ridebeam.com>
  Date:   2021-05-27 (Thu, 27 May 2021)

  Changed paths:
    M llvm/include/llvm/IR/ValueSymbolTable.h
    M llvm/lib/IR/Function.cpp
    M llvm/lib/IR/Module.cpp
    M llvm/lib/IR/Value.cpp
    M llvm/lib/IR/ValueSymbolTable.cpp
    A llvm/test/Assembler/non-global-value-max-name-size.ll

  Log Message:
  -----------
  Fix non-global-value-max-name-size not considered by LLParser

`non-global-value-max-name-size` is used by `Value` to cap the length of local value name. However, this flag is not considered by `LLParser`, which leads to unexpected `use of undefined value error`. The fix is to move the responsibility of capping the length to `ValueSymbolTable`.

The test is the one provided by [[ https://bugs.llvm.org/show_bug.cgi?id=45899 | Mikael in the bug report ]].

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D102707