[all-commits] [llvm/llvm-project] 5e2fac: [AMDGPU] Fix kernel LDS lowering for constants

Stanislav Mekhanoshin via All-commits all-commits at lists.llvm.org
Wed May 26 11:35:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5e2facb922840bfd03eb116eaeead039df021275
      https://github.com/llvm/llvm-project/commit/5e2facb922840bfd03eb116eaeead039df021275
  Author: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
  Date:   2021-05-26 (Wed, 26 May 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp
    M llvm/test/CodeGen/AMDGPU/ds_read2.ll
    M llvm/test/CodeGen/AMDGPU/ds_write2.ll
    M llvm/test/CodeGen/AMDGPU/lower-kernel-lds-constexpr.ll

  Log Message:
  -----------
  [AMDGPU] Fix kernel LDS lowering for constants

There is a trivial but severe bug in the recent code collecting
LDS globals used by kernel. It aborts scan on the first constant
without scanning further uses. That leads to LDS overallocation
with multiple kernels in certain cases.

Differential Revision: https://reviews.llvm.org/D103190




More information about the All-commits mailing list