[all-commits] [llvm/llvm-project] a2a65a: [docs] [CMake] Change recommendations for how to u...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a2a65a5bae3c503d40c219ef9ba460b1fb34d1bf
      https://github.com/llvm/llvm-project/commit/a2a65a5bae3c503d40c219ef9ba460b1fb34d1bf
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M llvm/docs/CMake.rst

  Log Message:
  -----------
  [docs] [CMake] Change recommendations for how to use LLVM_DEFINITIONS

LLVM_DEFINITIONS is a string variable containing a list of arguments
to pass to the compiler. When CMake's add_definitions is passed a
string variable, this is interpreted as one argument. To make it
behave properly, the string variable needs to be split into a list.

Despite the fact that add_definitions isn't supposed to be used like
the LLVM docs recommended, it worked fine in practice in many cases.
If the first argument in LLVM_DEFINITIONS is of the form -DFOO=42
instead of plain -DFOO, the rest of the string is treated as value
to this define. I.e. if LLVM_DEFINITIONS consists of `-DFOO=42 -DBAR`,
CMake ended up passing `-DFOO="42 -DBAR"` to the compiler.

See https://gitlab.kitware.com/cmake/cmakissues/22162
for discussion on the matter.

Changing LLVM_DEFINITIONS to be a list variable would possibly be
more disruptive; instead keep the variable defined as before but
change the recommendation for how to use it. Then projects using it
can gradually be updated to follow the new recommendation.

Differential Revision: https://reviews.llvm.org/D103044


  Commit: 3a6be27978aa3e83e9dc2ff2402b2569ce0686fd
      https://github.com/llvm/llvm-project/commit/3a6be27978aa3e83e9dc2ff2402b2569ce0686fd
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M libcxx/include/__locale

  Log Message:
  -----------
  [libcxx] Make the visibility attributes consistent for __narrow_to_utf8/__widen_from_utf8

Use the same visiblity attributes as for all other template
specializations in the same file; declare the specialization itself
using _LIBCPP_TYPE_VIS, and don't use _LIBCPP_EXPORTED_FROM_ABI on
the destructor. Methods that are excluded from the ABI are marked
with _LIBCPP_INLINE_VISIBILITY.

This makes the vtable exported from DLL builds of libc++. Practically,
it doesn't make any difference for the CI configuration, but it
can make a difference in mingw setups.

Differential Revision: https://reviews.llvm.org/D102717


  Commit: ec402f1d5da02dfbdc87d031ff99d7dbcada336f
      https://github.com/llvm/llvm-project/commit/ec402f1d5da02dfbdc87d031ff99d7dbcada336f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into UNSUPPORTED

This particular test relies on internal details from the libc++
filesystem implementation header, and those details are structured
differently in the implementation for Windows.

Differential Revision: https://reviews.llvm.org/D102357


Compare: https://github.com/llvm/llvm-project/compare/6a2869cf1e5b...ec402f1d5da0