[all-commits] [llvm/llvm-project] 2367a7: [JITLink][MachO][arm64] Use a more descriptive tes...

lhames via All-commits all-commits at lists.llvm.org
Tue May 25 12:19:36 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2367a7bdab36cf9c51b4d2b1d726f46ed5b1a2c6
      https://github.com/llvm/llvm-project/commit/2367a7bdab36cf9c51b4d2b1d726f46ed5b1a2c6
  Author: Lang Hames <lhames at gmail.com>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M llvm/test/ExecutionEngine/JITLink/AArch64/MachO_arm64_relocations.s

  Log Message:
  -----------
  [JITLink][MachO][arm64] Use a more descriptive test name.


  Commit: 249cd9dd6002836b6d4b89a940149d518e8aa48b
      https://github.com/llvm/llvm-project/commit/249cd9dd6002836b6d4b89a940149d518e8aa48b
  Author: Lang Hames <lhames at gmail.com>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/MachO_arm64.cpp
    M llvm/test/ExecutionEngine/JITLink/AArch64/MachO_arm64_relocations.s

  Log Message:
  -----------
  [JITLink][MachO][arm64] Build GOT entries for defined symbols too.

During the generic x86-64 support refactor in ecf6466f01c52 the implementation
of MachO_arm64_GOTAndStubsBuilder::isGOTEdgeToFix was altered to only return
true for external symbols. This behavior is incorrect: GOT entries may be
required for defined symbols (e.g. in the large code model).

This patch fixes the bug and adds a test case for it (renaming an old test
case to avoid any ambiguity).


Compare: https://github.com/llvm/llvm-project/compare/dc2aa4767601...249cd9dd6002


More information about the All-commits mailing list