[all-commits] [llvm/llvm-project] 187228: [scudo] Rework dieOnMapUnmapError

Kostya Kortchinsky via All-commits all-commits at lists.llvm.org
Tue May 25 08:28:16 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1872283457fc1617fa750a11abdfd44e881dfcdb
      https://github.com/llvm/llvm-project/commit/1872283457fc1617fa750a11abdfd44e881dfcdb
  Author: Kostya Kortchinsky <kostyak at google.com>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/common.cpp
    M compiler-rt/lib/scudo/standalone/common.h
    M compiler-rt/lib/scudo/standalone/fuchsia.cpp
    M compiler-rt/lib/scudo/standalone/linux.cpp
    M compiler-rt/lib/scudo/standalone/string_utils.cpp
    M compiler-rt/lib/scudo/standalone/string_utils.h

  Log Message:
  -----------
  [scudo] Rework dieOnMapUnmapError

Said function had a few shortfalls:
- didn't set an abort message on Android
- was logged on several lines
- didn't provide extra information like the size requested if OOM'ing

This improves the function to address those points.

Differential Revision: https://reviews.llvm.org/D103034




More information about the All-commits mailing list