[all-commits] [llvm/llvm-project] 1dee47: [lldb][NFC] Remove misleading ModulePass base clas...

[Raphael Isemann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1dee479ff632ef841ca7b28485779d898dd15e84
      https://github.com/llvm/llvm-project/commit/1dee479ff632ef841ca7b28485779d898dd15e84
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-05-25 (Tue, 25 May 2021)

  Changed paths:
    M lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.h

  Log Message:
  -----------
  [lldb][NFC] Remove misleading ModulePass base class for IRForTarget

IRForTarget is never used by a pass manager or any other interface that requires
this class to inherit from `Pass`.

Also IRForTarget doesn't implement the current interface correctly because it
uses the `runOnModule` return value to indicate success/failure instead of
changed/not-changed, so if this ever ends up being used as a pass it would most
likely not work as intended.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D102677