[all-commits] [llvm/llvm-project] 42a9c0: [lldb] Reland "Fix UB in half2float" to fix the ub...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon May 24 06:24:04 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 42a9c0c80c23fa0de3e3b00fef0dfa6d85e18e55
      https://github.com/llvm/llvm-project/commit/42a9c0c80c23fa0de3e3b00fef0dfa6d85e18e55
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-05-24 (Mon, 24 May 2021)

  Changed paths:
    M lldb/source/Core/DumpDataExtractor.cpp

  Log Message:
  -----------
  [lldb] Reland "Fix UB in half2float" to fix the ubsan bot.

This relands part of the UB fix in 4b074b49be206306330076b9fa40632ef1960823.
The original commit also added some additional tests that uncovered some
other issues (see D102845). I landed all the passing tests in
48780527dd6820698f3537f5ebf76499030ee349 and this patch is now just fixing
the UB in half2float. See D102846 for a proposed rewrite of the function.

Original commit message:

  The added DumpDataExtractorTest uncovered that this is lshifting a negative
  integer which upsets ubsan and breaks the sanitizer bot. This patch just
  changes the variable we shift to be unsigned.




More information about the All-commits mailing list