[all-commits] [llvm/llvm-project] 5d9ea3: [UpdateTestChecks] Default --x86_scrub_rip to False

Fangrui Song via All-commits all-commits at lists.llvm.org
Fri May 21 19:26:30 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d9ea36baffe682649923d29161cc58ca3d1a243
      https://github.com/llvm/llvm-project/commit/5d9ea36baffe682649923d29161cc58ca3d1a243
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-05-21 (Fri, 21 May 2021)

  Changed paths:
    M llvm/test/CodeGen/X86/2009-03-23-MultiUseSched.ll
    M llvm/test/CodeGen/X86/WidenArith.ll
    M llvm/test/CodeGen/X86/abi-isel.ll
    M llvm/test/CodeGen/X86/xor.ll
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-basic.ll
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-basic.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-constant-pool.ll
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-constant-pool.ll.expected
    R llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_function_name.ll
    R llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_function_name.ll.expected
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_generated_funcs.ll.generated.expected
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_generated_funcs.ll.nogenerated.expected
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/basic.test
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/x86-basic.test
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/x86-constant-pool.test
    R llvm/test/tools/UpdateTestChecks/update_llc_test_checks/x86-function-name.test
    M llvm/utils/UpdateTestChecks/asm.py
    M llvm/utils/update_llc_test_checks.py

  Log Message:
  -----------
  [UpdateTestChecks] Default --x86_scrub_rip to False

True is a bad default: the useful symbol names and `@GOTPCREL` are scrubbed.

Change the default and add global variable tests to x86-basic.ll
(renamed from x86_function_name.ll since we now also test variables).
I updated some tests to show the differences.

Updated LCPI regex to include Darwin style `LCPI_[0-9]+_[0-9]+` (no
leading dot).

Reviewed By: pengfei

Differential Revision: https://reviews.llvm.org/D102588




More information about the All-commits mailing list