[all-commits] [llvm/llvm-project] 7a29a1: [Verifier] Move some atomicrmw/cmpxchg checks to i...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7a29a1230148385e93493891cc7eb7f7f3b4a6cb
      https://github.com/llvm/llvm-project/commit/7a29a1230148385e93493891cc7eb7f7f3b4a6cb
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2021-05-21 (Fri, 21 May 2021)

  Changed paths:
    M llvm/include/llvm/IR/Instructions.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/IR/Instructions.cpp
    M llvm/lib/IR/Verifier.cpp
    A llvm/test/Assembler/cmpxchg-ordering-2.ll
    A llvm/test/Assembler/cmpxchg-ordering-3.ll
    A llvm/test/Assembler/cmpxchg-ordering-4.ll
    A llvm/test/Assembler/cmpxchg-ordering.ll
    A llvm/test/Bitcode/Inputs/invalid-cmpxchg-ordering-2.bc
    A llvm/test/Bitcode/Inputs/invalid-cmpxchg-ordering-3.bc
    A llvm/test/Bitcode/Inputs/invalid-cmpxchg-ordering-4.bc
    A llvm/test/Bitcode/Inputs/invalid-cmpxchg-ordering.bc
    M llvm/test/Bitcode/invalid.test

  Log Message:
  -----------
  [Verifier] Move some atomicrmw/cmpxchg checks to instruction creation

These checks already exist as asserts when creating the corresponding
instruction. Anybody creating these instructions already need to take
care to not break these checks.

Move the checks for success/failure ordering in cmpxchg from the
verifier to the LLParser and BitcodeReader plus an assert.

Add some tests for cmpxchg ordering. The .bc files are created from the
.ll files with an llvm-as with these checks disabled.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D102803