[all-commits] [llvm/llvm-project] cf725d: [DebugInfo] Handle DIArgList in FastISel or Global...

Stephen Tozer via All-commits all-commits at lists.llvm.org
Thu May 20 09:38:46 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cf725dde9cb7379496f896f465f3faad511c331b
      https://github.com/llvm/llvm-project/commit/cf725dde9cb7379496f896f465f3faad511c331b
  Author: Stephen Tozer <Stephen.Tozer at Sony.com>
  Date:   2021-05-20 (Thu, 20 May 2021)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
    M llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
    M llvm/test/DebugInfo/X86/debug_value_list_selectiondag.ll

  Log Message:
  -----------
  [DebugInfo] Handle DIArgList in FastISel or GlobalIsel

Currently, variadic dbg.values (i.e. those using a DIArgList as part of
their location) are not handled properly by FastISel or GlobalISel, and
will produce invalid DBG_VALUE instructions if they encounter them. This
patch fixes this issue by emitting undef DBG_VALUE instructions for
variadic dbg.values, so that no incorrect instruction is produced and
any prior variable location is terminated.

This is simply a quick-fix to prevent errors; a correct implementation
should come later for these ISel pipelines to ensure that we do not drop
debug information unnecessarily.

Differential Revision: https://reviews.llvm.org/D102500




More information about the All-commits mailing list