[all-commits] [llvm/llvm-project] d18fb0: [libomptarget][amdgpu] Remove majority of fatal er...

[Jon Chesterfield via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d18fb09c693970d1fad09e1ca4b595524af0c842
      https://github.com/llvm/llvm-project/commit/d18fb09c693970d1fad09e1ca4b595524af0c842
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-05-20 (Thu, 20 May 2021)

  Changed paths:
    M openmp/libomptarget/plugins/amdgpu/impl/data.cpp
    M openmp/libomptarget/plugins/amdgpu/impl/internal.h
    M openmp/libomptarget/plugins/amdgpu/impl/system.cpp
    M openmp/libomptarget/plugins/amdgpu/impl/utils.cpp
    M openmp/libomptarget/plugins/amdgpu/src/rtl.cpp

  Log Message:
  -----------
  [libomptarget][amdgpu] Remove majority of fatal errors

[libomptarget][amdgpu] Remove majority of fatal errors

Replaces most calls to exit() with returning an error to the library entry
point. Minor changes to error handling for clear bugs, remove some dead code.

Each exit() call site replaced is either in a library entry point or a
function that already returns error codes on some paths. The existing handling
is not well tested but replacing exit() with a fallback path should be a strict
improvement.

Remaining two early exit points are an abort() from a callback and exit() from
within msgpack. Fixes for those are less obvious and left for a later patch.

Reviewed By: pdhaliwal

Differential Revision: https://reviews.llvm.org/D102346