[all-commits] [llvm/llvm-project] 6539a8: [CSSPGO] Avoid deleting probe instruction in FoldV...

ictwanglei via All-commits all-commits at lists.llvm.org
Wed May 19 13:40:00 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6539a80bc9e8a8587a199e10caa843b40e2f2c71
      https://github.com/llvm/llvm-project/commit/6539a80bc9e8a8587a199e10caa843b40e2f2c71
  Author: wlei <wlei at fb.com>
  Date:   2021-05-19 (Wed, 19 May 2021)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp
    A llvm/test/Transforms/SampleProfile/pseudo-probe-dangle3.ll

  Log Message:
  -----------
  [CSSPGO] Avoid deleting probe instruction in FoldValueComparisonIntoPredecessors

This change tries to fix a place missing `moveAndDanglePseudoProbes `. In FoldValueComparisonIntoPredecessors, it folds the BB into predecessors and then marked the BB unreachable. However, the original logic from the BB is still alive, deleting the probe will mislead the SampleLoader mark it as zero count sample.

Reviewed By: hoy, wenlei

Differential Revision: https://reviews.llvm.org/D102721




More information about the All-commits mailing list