[all-commits] [llvm/llvm-project] 722c39: [HIP] Tighten checks in hip-include-path.hip test ...

Björn Pettersson via All-commits all-commits at lists.llvm.org
Wed May 19 04:16:17 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 722c39fef5ab611b3196e964bb3177a5ab473355
      https://github.com/llvm/llvm-project/commit/722c39fef5ab611b3196e964bb3177a5ab473355
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2021-05-19 (Wed, 19 May 2021)

  Changed paths:
    M clang/test/Driver/hip-include-path.hip

  Log Message:
  -----------
  [HIP] Tighten checks in hip-include-path.hip test case

The checks (both positive and negative checks) in the test case
hip-include-path.hip could mistakenly end up matching the string
"clang" from the InstalledDir in case the build dir for example
was named "/home/username/build-clang/". Intention with this
patch is to tighten up the checks a bit to filter our the
part of the paths that match with InstalledDir when doing the
checks, as well as matching "/lib/clang/" rather than
just "clang/".

Problem was found when building with
  -DCLANG_DEFAULT_RTLIB=compiler-rt
  -DCLANG_DEFAULT_CXX_STDLIB=libc++
and having "clang/" in the path to the build dir.

Reviewed By: yaxunl

Differential Revision: https://reviews.llvm.org/D102723




More information about the All-commits mailing list