[all-commits] [llvm/llvm-project] e102fd: Reformat GSYMCreator.cpp

[Simon Giesecke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e102fd50f9c62ffe2d0fe04827d0a8b85250118f
      https://github.com/llvm/llvm-project/commit/e102fd50f9c62ffe2d0fe04827d0a8b85250118f
  Author: Simon Giesecke <simon.giesecke at snowflake.com>
  Date:   2021-05-19 (Wed, 19 May 2021)

  Changed paths:
    M llvm/lib/DebugInfo/GSYM/GsymCreator.cpp

  Log Message:
  -----------
  Reformat GSYMCreator.cpp

Differential Revision: https://reviews.llvm.org/D102483


  Commit: f29c4c60978c41914fadb064eec46086e66f07c0
      https://github.com/llvm/llvm-project/commit/f29c4c60978c41914fadb064eec46086e66f07c0
  Author: Simon Giesecke <simon.giesecke at snowflake.com>
  Date:   2021-05-19 (Wed, 19 May 2021)

  Changed paths:
    M llvm/lib/DebugInfo/GSYM/GsymCreator.cpp

  Log Message:
  -----------
  Avoid calculating the string hash twice in GsymCreator::insertString.

Do the single hash calculation before acquiring the lock, to reduce
lock contention. If Copy is true, and the string was not yet contained
in the StringStorage, use the new address from StringStorage, but
reuse the hash we already calculated.

Differential Revision: https://reviews.llvm.org/D102484


  Commit: 4ea4d9c066b6e6f24756538d3d366d559499be3d
      https://github.com/llvm/llvm-project/commit/4ea4d9c066b6e6f24756538d3d366d559499be3d
  Author: Simon Giesecke <simon.giesecke at snowflake.com>
  Date:   2021-05-19 (Wed, 19 May 2021)

  Changed paths:
    M llvm/lib/DebugInfo/GSYM/GsymCreator.cpp

  Log Message:
  -----------
  Move FunctionInfo in addFunctionInfo rather than copying.

Differential Revision: https://reviews.llvm.org/D102485


  Commit: 81b2fcf26fcaff1dfc7fcc30eb0de79d643e85e6
      https://github.com/llvm/llvm-project/commit/81b2fcf26fcaff1dfc7fcc30eb0de79d643e85e6
  Author: Simon Giesecke <simon.giesecke at snowflake.com>
  Date:   2021-05-19 (Wed, 19 May 2021)

  Changed paths:
    M llvm/include/llvm/DebugInfo/GSYM/GsymCreator.h
    M llvm/lib/DebugInfo/GSYM/GsymCreator.cpp

  Log Message:
  -----------
  Use a non-recursive mutex in GsymCreator.

There doesn't seem to be a need to support recursive locking,
and a recursive mutex is unnecessarily inefficient.

Differential Revision: https://reviews.llvm.org/D102486


Compare: https://github.com/llvm/llvm-project/compare/c1dc267258e0...81b2fcf26fca