[all-commits] [llvm/llvm-project] 9f4f01: [libcxx][test] Attempt to make debug mode tests mo...

chbessonova via All-commits all-commits at lists.llvm.org
Tue May 18 05:53:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f4f012c10266c2117f80b7c7eb699aadef0589d
      https://github.com/llvm/llvm-project/commit/9f4f012c10266c2117f80b7c7eb699aadef0589d
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2021-05-18 (Tue, 18 May 2021)

  Changed paths:
    M libcxx/test/libcxx/containers/sequences/deque/pop_back_empty.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.cons/db_copy.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/emplace_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/erase_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/erase_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/erase_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/erase_iter_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/erase_iter_iter_db3.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/erase_iter_iter_db4.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/insert_iter_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/insert_iter_rvalue_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/insert_iter_size_value_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/insert_iter_value_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.modifiers/pop_back_db1.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.ops/db_splice_pos_list.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.ops/db_splice_pos_list_iter.pass.cpp
    M libcxx/test/libcxx/containers/sequences/list/list.ops/db_splice_pos_list_iter_iter.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_back.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_back_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_cback.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_cback_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_cfront.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_cfront_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_cindex.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_cindex_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_front.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_front_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_index.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_index_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_11.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_12.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_13.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_14.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_15.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_2.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_3.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_4.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_5.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_6.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/sequences/vector/pop_back_empty.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/bucket_size.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_bucket.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_insert_hint_const_lvalue.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_insert_hint_rvalue.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_swap_1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/max_load_factor.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db3.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db4.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/bucket.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/bucket_size.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_insert_hint_const_lvalue.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_insert_hint_rvalue.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_swap_1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/max_load_factor.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db3.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db4.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/bucket.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/bucket_size.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_insert_hint_const_lvalue.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_swap_1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db3.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db4.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/max_load_factor.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/bucket.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/bucket_size.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_insert_hint_const_lvalue.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_10.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_8.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_swap_1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/erase_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/erase_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db2.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db3.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db4.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/max_load_factor.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/back.const.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/back.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_back.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_back_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_cback.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_cback_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_cfront.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_cfront_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_cindex.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_cindex_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_front.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_front_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_index.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/db_index_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/front.const.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/front.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/index.const.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.access/index.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_10.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_11.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_12.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_13.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_14.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_15.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_3.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_4.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_5.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_6.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_8.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db1.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db3.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db4.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db2.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db3.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db4.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db5.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db6.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db7.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db8.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_pop_back_db1.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/insert_iter_char_db1.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/insert_iter_iter_iter_db1.pass.cpp
    M libcxx/test/libcxx/strings/basic.string/string.modifiers/insert_iter_size_char_db1.pass.cpp
    M libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/dereference.pass.cpp
    M libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/dereference_const.pass.cpp
    M libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/dereference_const_rvalue.pass.cpp
    M libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/dereference_rvalue.pass.cpp
    M libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/op_arrow.pass.cpp
    M libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/op_arrow_const.pass.cpp
    A libcxx/test/support/debug_macros.h

  Log Message:
  -----------
  [libcxx][test] Attempt to make debug mode tests more bulletproof

The problem with debug mode tests is that it isn't known which particular
_LIBCPP_ASSERT causes the test to exit, and as shown by
https://reviews.llvm.org/D100029 and 2908eb20ba7 it might be not the
expected one.

The patch adds TEST_LIBCPP_ASSERT_FAILURE macro that allows checking
_LIBCPP_ASSERT message to ensure we caught an expected failure.

Reviewed By: Quuxplusone, ldionne

Differential Revision: https://reviews.llvm.org/D100595




More information about the All-commits mailing list