[all-commits] [llvm/llvm-project] 2182ed: [LLDB] Switch from using member_clang_type.GetByte...

Shafik Yaghmour via All-commits all-commits at lists.llvm.org
Mon May 17 10:37:01 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2182eda3062471e2e6994307c46ffcca7e39ecff
      https://github.com/llvm/llvm-project/commit/2182eda3062471e2e6994307c46ffcca7e39ecff
  Author: Shafik Yaghmour <syaghmour at apple.com>
  Date:   2021-05-17 (Mon, 17 May 2021)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

  Log Message:
  -----------
  [LLDB] Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember

We have a bug in which using member_clang_type.GetByteSize() triggers record
layout and during this process since the record was not yet complete we ended
up reaching a record that had not been layed out yet.
Using member_type->GetByteSize() avoids this situation since it relies on size
from DWARF and will not trigger record layout.

For reference: rdar://77293040

Differential Revision: https://reviews.llvm.org/D102445




More information about the All-commits mailing list