[all-commits] [llvm/llvm-project] ec2f73: [clangd][QueryDriver] Dont check for existence of ...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec2f7376e39fa5d820d059b6e83e69690fe6315f
      https://github.com/llvm/llvm-project/commit/ec2f7376e39fa5d820d059b6e83e69690fe6315f
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-05-17 (Mon, 17 May 2021)

  Changed paths:
    M clang-tools-extra/clangd/QueryDriverDatabase.cpp

  Log Message:
  -----------
  [clangd][QueryDriver] Dont check for existence of driver

Execute implementations already checks for permissions and existence
and returns relevant errors as necessary, so instead of printing our own errors,
we just print theirs.

This also fixes a case in windows where the driver might be missing the `.exe`
suffix. Previously, clangd would reject such a driver because sys::fs::exists is
strict, whereas the underlying Execute implementation would check with `.exe`
suffix too.

Fixes https://github.com/clangd/clangd/issues/93

Differential Revision: https://reviews.llvm.org/D102431