[all-commits] [llvm/llvm-project] d62413: [lld][X86] Restore gotEntrySize.

Harald van Dijk via All-commits all-commits at lists.llvm.org
Sun May 16 16:13:28 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d62413452fc632023c531d4336254f7b3a54a600
      https://github.com/llvm/llvm-project/commit/d62413452fc632023c531d4336254f7b3a54a600
  Author: Harald van Dijk <harald at gigawatt.nl>
  Date:   2021-05-17 (Mon, 17 May 2021)

  Changed paths:
    M lld/ELF/Arch/X86_64.cpp
    M lld/ELF/Symbols.cpp
    M lld/ELF/SyntheticSections.cpp
    M lld/ELF/Target.h
    A lld/test/ELF/x86-x32-plt.s

  Log Message:
  -----------
  [lld][X86] Restore gotEntrySize.

D62727 removed GotEntrySize and GotPltEntrySize with a comment that they
are always equal to wordsize(), but that is not entirely true: X32 has a
word size of 4, but needs 8-byte GOT entries. This restores gotEntrySize
for both, adjusted for current naming conventions, but defaults it to
config->wordsize to keep things simple for architectures other than
x86_64.

This partially reverts D62727.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D102509




More information about the All-commits mailing list