[all-commits] [llvm/llvm-project] 8c7274: [LowerConstantIntrinsics] reuse isManifestLogic fr...

[Nick Desaulniers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c72749bd92d35397e93908bc5a504d4cbcef1cb
      https://github.com/llvm/llvm-project/commit/8c72749bd92d35397e93908bc5a504d4cbcef1cb
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    M llvm/include/llvm/IR/Constant.h
    M llvm/lib/Analysis/ConstantFolding.cpp
    M llvm/lib/IR/Constants.cpp
    M llvm/lib/Transforms/Scalar/LowerConstantIntrinsics.cpp
    M llvm/test/Transforms/LowerConstantIntrinsics/constant-intrinsics.ll

  Log Message:
  -----------
  [LowerConstantIntrinsics] reuse isManifestLogic from ConstantFolding

GlobalVariables are Constants, yet should not unconditionally be
considered true for __builtin_constant_p.

Via the LangRef
https://llvm.org/docs/LangRef.html#llvm-is-constant-intrinsic:

    This intrinsic generates no code. If its argument is known to be a
    manifest compile-time constant value, then the intrinsic will be
    converted to a constant true value. Otherwise, it will be converted
    to a constant false value.

    In particular, note that if the argument is a constant expression
    which refers to a global (the address of which _is_ a constant, but
    not manifest during the compile), then the intrinsic evaluates to
    false.

Move isManifestConstant from ConstantFolding to be a method of
Constant so that we can reuse the same logic in
LowerConstantIntrinsics.

pr/41459

Reviewed By: rsmith, george.burgess.iv

Differential Revision: https://reviews.llvm.org/D102367