[all-commits] [llvm/llvm-project] c12c81: [libcxx] [test] Change the generic_string_alloc te...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri May 14 01:57:23 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c12c8124e14217779eb5b8d3a2a92a6469a799e7
      https://github.com/llvm/llvm-project/commit/c12c8124e14217779eb5b8d3a2a92a6469a799e7
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/generic_string_alloc.pass.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Change the generic_string_alloc test to test conversions to all char types

On windows, the native path char type is wchar_t - therefore, this test
didn't actually do the conversion that the test was supposed to exercise.

The charset conversions on windows do cause extra allocations outside of
the provided allocator though, so that bit of the test has to be waived
now that the test actually does something. (Other tests have similar
TEST_NOT_WIN32() for allocation checks for charset conversions.)

Also fix a typo, and amend the path.native.obs/string_alloc test to
test char8_t, too.

Differential Revision: https://reviews.llvm.org/D102360




More information about the All-commits mailing list