[all-commits] [llvm/llvm-project] dd98ea: [ASTMatchers] NFC: Fix formatting around forFuncti...

[NoQ via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd98ea528c0c23f5fee6d3dbafc261b81cca9f0d
      https://github.com/llvm/llvm-project/commit/dd98ea528c0c23f5fee6d3dbafc261b81cca9f0d
  Author: Artem Dergachev <artem.dergachev at gmail.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M clang/docs/LibASTMatchersReference.html
    M clang/include/clang/ASTMatchers/ASTMatchers.h

  Log Message:
  -----------
  [ASTMatchers] NFC: Fix formatting around forFunction().

Differential Revision: https://reviews.llvm.org/D102303


  Commit: 6a079dfdc992706408f2bde84c48bf76e52c4311
      https://github.com/llvm/llvm-project/commit/6a079dfdc992706408f2bde84c48bf76e52c4311
  Author: Artem Dergachev <artem.dergachev at gmail.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M clang/docs/LibASTMatchersReference.html
    M clang/include/clang/ASTMatchers/ASTMatchers.h
    M clang/lib/ASTMatchers/Dynamic/Registry.cpp
    M clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp

  Log Message:
  -----------
  [ASTMatchers] Add forCallable(), a generalization of forFunction().

The new matcher additionally covers blocks and Objective-C methods.

This matcher actually makes sure that the statement truly belongs
to that declaration's body. forFunction() incorrectly reported that
a statement in a nested block belonged to the surrounding function.

forFunction() is now deprecated due to the above footgun, in favor of
forCallable(functionDecl()) when only functions need to be considered.

Differential Revision: https://reviews.llvm.org/D102213


  Commit: 46c6c08c9428a36bdf88f51b1a14164aa4cbb93e
      https://github.com/llvm/llvm-project/commit/46c6c08c9428a36bdf88f51b1a14164aa4cbb93e
  Author: Artem Dergachev <artem.dergachev at gmail.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp
    M clang-tools-extra/clang-tidy/utils/Aliasing.cpp
    M clang-tools-extra/clang-tidy/utils/Aliasing.h
    M clang-tools-extra/test/clang-tidy/checkers/bugprone-infinite-loop.cpp
    A clang-tools-extra/test/clang-tidy/checkers/bugprone-infinite-loop.mm

  Log Message:
  -----------
  [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

Take advantage of the new ASTMatcher added in D102213 to fix massive false negatives of the infinite loop checker on Objective-C.

Differential Revision: https://reviews.llvm.org/D102214


  Commit: 5ad2eeeadaf15856332f66ed7c244d52a86b0be7
      https://github.com/llvm/llvm-project/commit/5ad2eeeadaf15856332f66ed7c244d52a86b0be7
  Author: Artem Dergachev <artem.dergachev at gmail.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp
    M clang-tools-extra/test/clang-tidy/checkers/bugprone-infinite-loop.mm

  Log Message:
  -----------
  [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages.

If the loop condition is a value of an instance variable, a property value,
or a message result value, it's a good indication that the loop is not infinite
and we have a really hard time proving the opposite so suppress the warning.

Differential Revision: https://reviews.llvm.org/D102294


Compare: https://github.com/llvm/llvm-project/compare/0d8f91d2a999...5ad2eeeadaf1