[all-commits] [llvm/llvm-project] 23e914: Modules: Rename ModuleBuildFailed => DisableGenera...

Duncan P. N. Exon Smith via All-commits all-commits at lists.llvm.org
Thu May 13 10:23:03 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23e9146fba298d38142337b615e17067fb8ccb91
      https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8ccb91
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M clang/include/clang/Frontend/CompilerInstance.h
    M clang/lib/Frontend/CompilerInstance.cpp

  Log Message:
  -----------
  Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

Rename CompilerInstance's ModuleBuildFailed field to
DisableGeneratingGlobalModuleIndex, which more precisely describes its
role. Otherwise, it's hard to suss out how it's different from
ModuleLoader::HadFatalFailure, and what sort of code simplifications are
safe.

Differential Revision: https://reviews.llvm.org/D101670




More information about the All-commits mailing list