[all-commits] [llvm/llvm-project] 8f9835: [AMDGPU] Only allow global fp atomics with unsafe ...

Stanislav Mekhanoshin via All-commits all-commits at lists.llvm.org
Thu May 13 08:52:44 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f98356bb53dca07a86bf098556d446e0d5af6fe
      https://github.com/llvm/llvm-project/commit/8f98356bb53dca07a86bf098556d446e0d5af6fe
  Author: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/fp64-atomics-gfx90a.ll
    M llvm/test/CodeGen/AMDGPU/global-atomics-fp.ll

  Log Message:
  -----------
  [AMDGPU] Only allow global fp atomics with unsafe option

Previously we were allowing to use FP atomics without
-amdgpu-unsafe-fp-atomics option if a scope is less then
system. This is not safe just as well if we have UC memory.

This change only allows global and flat FP atomics with
the unsafe option. Consequentially that makes a check for
denorm mode redundant since we skip it with the unsafe
option and do not have a way to produce these instructions
without it anyway.

Differential Revision: https://reviews.llvm.org/D102347




More information about the All-commits mailing list