[all-commits] [llvm/llvm-project] bf068e: [mlir] Do not use pass labels in unrolled Progress...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bf068e1077a44fcb52fdf2aeb8f03f80517b64ab
      https://github.com/llvm/llvm-project/commit/bf068e1077a44fcb52fdf2aeb8f03f80517b64ab
  Author: Matthias Springer <springerm at google.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M mlir/lib/Conversion/VectorToSCF/ProgressiveVectorToSCF.cpp
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-3d.mlir

  Log Message:
  -----------
  [mlir] Do not use pass labels in unrolled ProgressiveVectorToSCF

Do not rely on pass labels to detect if the pattern was already applied in the past (which allows for more some extra optimizations to avoid extra InsertOps and ExtractOps). Instead, check if these optimizations can be applied on-the-fly.

This also fixes a bug, where vector.insert and vector.extract ops sometimes disappeared in the middle of the pass because they get folded away, but the next application of the pattern expected them to be there.

Differential Revision: https://reviews.llvm.org/D102206