[all-commits] [llvm/llvm-project] c52cbe: [mlir] Fix masked vector transfer ops with broadcasts

Matthias Springer via All-commits all-commits at lists.llvm.org
Wed May 12 20:46:40 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c52cbe63e42fff8c1a95921effd35d7bb59301d3
      https://github.com/llvm/llvm-project/commit/c52cbe63e42fff8c1a95921effd35d7bb59301d3
  Author: Matthias Springer <springerm at google.com>
  Date:   2021-05-13 (Thu, 13 May 2021)

  Changed paths:
    M mlir/include/mlir/Interfaces/VectorInterfaces.h
    M mlir/include/mlir/Interfaces/VectorInterfaces.td
    M mlir/lib/Conversion/VectorToSCF/ProgressiveVectorToSCF.cpp
    M mlir/lib/Dialect/Vector/VectorOps.cpp
    M mlir/lib/Interfaces/VectorInterfaces.cpp
    M mlir/test/Dialect/Vector/invalid.mlir
    M mlir/test/Dialect/Vector/ops.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-1d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-2d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-3d.mlir

  Log Message:
  -----------
  [mlir] Fix masked vector transfer ops with broadcasts

Broadcast dimensions of a vector transfer op have no corresponding dimension in the mask vector. E.g., a 2-D TransferReadOp, where one dimension is a broadcast, can have a 1-D `mask` attribute.

This commit also adds a few additional transfer op integration tests for various combinations of broadcasts, masking, dim transposes, etc.

Differential Revision: https://reviews.llvm.org/D101745




More information about the All-commits mailing list