[all-commits] [llvm/llvm-project] ba38b7: [WebAssembly] Allow Wasm EH with Emscripten SjLj

Heejin Ahn via All-commits all-commits at lists.llvm.org
Wed May 12 13:28:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ba38b72ec2833bf8c54829a0fd7a8c968e6260d4
      https://github.com/llvm/llvm-project/commit/ba38b72ec2833bf8c54829a0fd7a8c968e6260d4
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2021-05-12 (Wed, 12 May 2021)

  Changed paths:
    M llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
    M llvm/test/CodeGen/WebAssembly/lower-em-ehsjlj-options.ll

  Log Message:
  -----------
  [WebAssembly] Allow Wasm EH with Emscripten SjLj

We explicitly made it error out in D101403, out of a good intention that
the error message will make people less confusing. Turns out, we weren't
failing all cases of wasm EH + SjLj; only a few cases were failing and
our client was able to get around by fixing source code, but now we made
it fail for all cases, even the cases that previously succeeded fail,
which we didn't intend. This reverts that change.

Reviewed By: tlively

Differential Revision: https://reviews.llvm.org/D102364




More information about the All-commits mailing list