[all-commits] [llvm/llvm-project] 993457: [libomptarget][amdgpu][nfc] Expand errorcheck macros

[Jon Chesterfield via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9934571eab9c6b3be22c4c8857bd3f4280b77843
      https://github.com/llvm/llvm-project/commit/9934571eab9c6b3be22c4c8857bd3f4280b77843
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-05-12 (Wed, 12 May 2021)

  Changed paths:
    M openmp/libomptarget/plugins/amdgpu/impl/data.cpp
    M openmp/libomptarget/plugins/amdgpu/impl/internal.h
    M openmp/libomptarget/plugins/amdgpu/impl/system.cpp
    M openmp/libomptarget/plugins/amdgpu/src/rtl.cpp

  Log Message:
  -----------
  [libomptarget][amdgpu][nfc] Expand errorcheck macros

[libomptarget][amdgpu][nfc] Expand errorcheck macros

These macros expand to continue, which is confusing, or exit,
which is incompatible with continuing execution on offloading fail.

Expanding the macros in place makes the code look untidy but the
control flow obvious and amenable to improving. In particular, exit
becomes easier to eliminate.

Reviewed By: pdhaliwal

Differential Revision: https://reviews.llvm.org/D102230