[all-commits] [llvm/llvm-project] 4b00ff: [DAGCombiner] Add test exposing bug in DAG combine.

Hendrik Greving via All-commits all-commits at lists.llvm.org
Wed May 12 07:22:37 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b00ffa767fc8a71c2eaf544cb6397f6db34eb6a
      https://github.com/llvm/llvm-project/commit/4b00ffa767fc8a71c2eaf544cb6397f6db34eb6a
  Author: Hendrik Greving <hgreving at google.com>
  Date:   2021-05-12 (Wed, 12 May 2021)

  Changed paths:
    A llvm/test/CodeGen/X86/dagcombine-dead-store.ll

  Log Message:
  -----------
  [DAGCombiner] Add test exposing bug in DAG combine.

Adds a test in X86, exposing a bug in DAG combine eliminating stores that
are the same value but no the same address space.

Differential Revision: https://reviews.llvm.org/D102243


  Commit: 762ac725bf9775536dda5b3dda13574f14a8c2b9
      https://github.com/llvm/llvm-project/commit/762ac725bf9775536dda5b3dda13574f14a8c2b9
  Author: Hendrik Greving <hgreving at google.com>
  Date:   2021-05-12 (Wed, 12 May 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/X86/dagcombine-dead-store.ll

  Log Message:
  -----------
  [DAGCombiner] Fix DAG combine store elimination, different address space.

Fixes a bug in the DAG combiner that eliminates the stores because it missed
to inspect the address space of the pointers.

%v = load %ptr_as1
// no chain side effect
store %v, %ptr_as2

As well as

store %v, %ptr_as1
store %v, %ptr_as2

Fixes a test for above in X86.

Differential Revision: https://reviews.llvm.org/D102096


Compare: https://github.com/llvm/llvm-project/compare/3fa6510f6ea0...762ac725bf97


More information about the All-commits mailing list