[all-commits] [llvm/llvm-project] 23596f: sanitizer_common: don't write into .rodata

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Tue May 11 22:54:28 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23596fece043fa04206dcd5b26b4ca832e6741db
      https://github.com/llvm/llvm-project/commit/23596fece043fa04206dcd5b26b4ca832e6741db
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-05-12 (Wed, 12 May 2021)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc

  Log Message:
  -----------
  sanitizer_common: don't write into .rodata

setlocale interceptor imitates a write into result,
which may be located in .rodata section.
This is the only interceptor that tries to do this and
I think the intention was to initialize the range for msan.
So do that instead. Writing into .rodata shouldn't happen
(without crashing later on the actual write) and this
traps on my local tsan experiments.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D102161




More information about the All-commits mailing list